Skip to content

Use JSON ingestion as schema definition extension#1205

Open
jwils wants to merge 1 commit into
joshuaw/json-ingestion-extension-modulesfrom
joshuaw/json-ingestion-default-extension
Open

Use JSON ingestion as schema definition extension#1205
jwils wants to merge 1 commit into
joshuaw/json-ingestion-extension-modulesfrom
joshuaw/json-ingestion-default-extension

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 20, 2026 •
edited
Loading

Why

Complete the extraction by loading JSON ingestion through the schema-definition extension API and removing the duplicated core JSON Schema implementation.

What

  • Wire ElasticGraph::JSONIngestion::SchemaDefinition::APIExtension explicitly into app, template, doctest, and spec-helper schema definition setup
  • Move JSON Schema artifact/results behavior out of core schema_definition
  • Remove JSON Schema field/type/index logic from core classes now provided by the extension
  • Keep JSON schema version enforcement configured through schema.enforce_json_schema_version false

Risk Assessment

Medium to high — this is the behavior-transfer layer, but it sits after the move/namespace/add-extension PRs so the remaining diff is mostly deletion and wiring.

References

  • Stacked on Add JSON ingestion schema extension modules #1204.
  • Local lint, type check, spellcheck, targeted specs, schema artifact dump/check, and documentation coverage passed.
  • Full local script/quick_build could not run because Docker and docker-compose are not installed, so no local datastore can be booted; GitHub CI should cover that environment.

@jwils jwils mentioned this pull request May 20, 2026
Open
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from f9fb615 to edc42c3 Compare May 20, 2026 20:03
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 2 times, most recently from 024c4ef to d8c3c70 Compare May 20, 2026 20:15
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from edc42c3 to 62013f0 Compare May 20, 2026 20:15
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from d8c3c70 to b78686f Compare May 21, 2026 02:49
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch 2 times, most recently from 1eec3a6 to f13769d Compare May 21, 2026 13:43
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from b78686f to 0b3844f Compare May 21, 2026 13:43
@jwils jwils marked this pull request as ready for review May 22, 2026 18:24
@myronmarston myronmarston mentioned this pull request May 22, 2026
Open
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from f13769d to ee7fe58 Compare May 22, 2026 22:41
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 0b3844f to 65f9a60 Compare May 22, 2026 22:41
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from ee7fe58 to 4170e75 Compare May 24, 2026 13:33
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 65f9a60 to 6be803f Compare May 24, 2026 13:33
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from 4170e75 to a49a787 Compare May 24, 2026 14:09
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 6be803f to 159afa8 Compare May 24, 2026 14:09
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from a49a787 to 68bd00b Compare May 24, 2026 14:24
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 159afa8 to 29e7e8e Compare May 24, 2026 14:24
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from 68bd00b to d4a6dcf Compare May 24, 2026 14:51
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 2 times, most recently from 31d7828 to 87c88c1 Compare May 24, 2026 15:00
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from d4a6dcf to 05163d1 Compare May 24, 2026 15:00
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 87c88c1 to e99c65f Compare May 24, 2026 15:36
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from 05163d1 to 97557eb Compare May 24, 2026 15:36
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from e99c65f to 6aea7ea Compare May 24, 2026 18:05
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch 8 times, most recently from d3dbe71 to ce30f97 Compare May 24, 2026 21:11
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 6aea7ea to 5015de6 Compare May 24, 2026 23:47
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from ce30f97 to 62d5349 Compare May 24, 2026 23:47
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 5015de6 to a80ca4e Compare May 24, 2026 23:50
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from 62d5349 to 96a43fd Compare May 24, 2026 23:50
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from a80ca4e to 95de439 Compare May 25, 2026 01:10
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from 96a43fd to c9e27aa Compare May 25, 2026 01:10
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 95de439 to c8ca744 Compare May 25, 2026 01:17
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch 2 times, most recently from 2633554 to 6a7badd Compare May 25, 2026 03:43
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from c8ca744 to e4f6b96 Compare May 25, 2026 03:44
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from 6a7badd to 39eec10 Compare May 25, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayousufi ayousufi Awaiting requested review from ayousufi ayousufi is a code owner

@BrianSigafoos-SQ BrianSigafoos-SQ Awaiting requested review from BrianSigafoos-SQ BrianSigafoos-SQ is a code owner

@bsorbo bsorbo Awaiting requested review from bsorbo bsorbo is a code owner

@jwondrusch jwondrusch Awaiting requested review from jwondrusch jwondrusch is a code owner

@myronmarston myronmarston Awaiting requested review from myronmarston myronmarston is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jwils